[webkit-reviews] review granted: [Bug 177308] eventInitDict parameter to GamepadEvent constructor should be optional : [Attachment 321443] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 21 13:44:55 PDT 2017


Sam Weinig <sam at webkit.org> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 177308: eventInitDict parameter to GamepadEvent constructor should be
optional
https://bugs.webkit.org/show_bug.cgi?id=177308

Attachment 321443: Patch

https://bugs.webkit.org/attachment.cgi?id=321443&action=review




--- Comment #4 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 321443
  --> https://bugs.webkit.org/attachment.cgi?id=321443
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321443&action=review

> Source/WebCore/ChangeLog:9
> +	   and Chrome. Having such dictionary parameter is also not valid Web
IDL:

Can you make this an error in the generator?


More information about the webkit-reviews mailing list