[webkit-reviews] review granted: [Bug 177205] webkitpy: Ignore failure to get updated selenium version : [Attachment 321453] Patch

[bugzilla-daemon at webkit.org]

Lucas Forschler <lforschler at apple.com> has granted Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 177205: webkitpy: Ignore failure to get updated selenium version
https://bugs.webkit.org/show_bug.cgi?id=177205

Attachment 321453: Patch

https://bugs.webkit.org/attachment.cgi?id=321453&action=review




--- Comment #11 from Lucas Forschler <lforschler at apple.com> ---
Comment on attachment 321453
  --> https://bugs.webkit.org/attachment.cgi?id=321453
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321453&action=review

> Tools/Scripts/webkitpy/thirdparty/__init__.py:182
> +			   break

We should consider writing a version check function, which would allow us to
use this logic for other components, if we needed similar logic in the future.
(one may already exist elsewhere in webkitpy)

> Tools/Scripts/webkitpy/thirdparty/__init__.py:185
> +	       url =
'https://pypi.python.org/packages/ac/d7/1928416439d066c60f26c87a8d1b78a8edd64c7
d05a0aa917fa97a8ee02d/selenium-3.5.0.tar.gz'

The other URLs include the hash, let's try to be consistent. 
Example:
installer.install(url="http://pypi.python.org/packages/source/J/Jinja2/Jinja2-2
.6.tar.gz#md5=1c49a8825c993bfdcf55bb36897d28a2",
					       
url_subpath="Jinja2-2.6/jinja2")

> Tools/Scripts/webkitpy/thirdparty/__init__.py:186
> +	       url_subpath = '{}/selenium'.format(minimum_version)

Can you include the '-' here, so the subpath follows existing convention
(selenium-3.5.0)