[webkit-reviews] review granted: [Bug 177306] REGRESSION(r221465) WKWebViews without WebGL delegate callbacks crash when WebGL contexts are created : [Attachment 321438] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 177306: REGRESSION(r221465) WKWebViews without WebGL delegate callbacks
crash when WebGL contexts are created
https://bugs.webkit.org/show_bug.cgi?id=177306

Attachment 321438: Patch

https://bugs.webkit.org/attachment.cgi?id=321438&action=review




--- Comment #2 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 321438
  --> https://bugs.webkit.org/attachment.cgi?id=321438
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321438&action=review

r=me

> Source/WebKit/UIProcess/Cocoa/NavigationState.mm:311
> +	   return completionHandler(WebGLAllowCreation);

I seem to remember Darin not liking this pattern and preferring doing this on 2
lines.

> Source/WebKit/UIProcess/Cocoa/NavigationState.mm:326
> +	   return completionHandler(WebGLAllowCreation);

ditto.