[webkit-reviews] review granted: [Bug 177289] Add long press and drag test : [Attachment 321402] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 177289: Add long press and drag test
https://bugs.webkit.org/show_bug.cgi?id=177289

Attachment 321402: Patch

https://bugs.webkit.org/attachment.cgi?id=321402&action=review




--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 321402
  --> https://bugs.webkit.org/attachment.cgi?id=321402
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321402&action=review

> LayoutTests/fast/events/touch/ios/long-press-then-drag-to-select-text.html:36
> +					      output += 'FAIL: failed to select
correct word as a result of a drag after long press. Incorrect selection: ' +
document.getSelection().toString();

Odd spacing here. Tabs?

> LayoutTests/fast/events/touch/ios/resources/basic-gestures.js:64
> +function longPressAtPointNoLift(X, Y)

The "NoLift" is awkward. Maybe pressAndHoldAtPoint?

> LayoutTests/fast/events/touch/ios/resources/basic-gestures.js:70
> +		  {

Canonical style would be to outdent opening and closing braces.

> LayoutTests/fast/events/touch/ios/resources/basic-gestures.js:105
> +	uiController.sendEventStream(JSON.stringify(eventStream), function()
{});
> +	uiController.uiScriptComplete();

These should be indented.

> LayoutTests/fast/events/touch/ios/resources/basic-gestures.js:151
> +	uiController.sendEventStream(JSON.stringify(eventStream), function()
{});
> +	uiController.uiScriptComplete();

Ditto.