[webkit-reviews] review granted: [Bug 177190] JSC Xcode build should use unified sources for platform independent files : [Attachment 321376] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Keith Miller
<keith_miller at apple.com>'s request for review:
Bug 177190: JSC Xcode build should use unified sources for platform independent
files
https://bugs.webkit.org/show_bug.cgi?id=177190

Attachment 321376: Patch

https://bugs.webkit.org/attachment.cgi?id=321376&action=review




--- Comment #9 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 321376
  --> https://bugs.webkit.org/attachment.cgi?id=321376
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321376&action=review

r=me

> Source/JavaScriptCore/ChangeLog:22
> +	   LowLevelInterpreter.cpp can't be added to the unified source list
yet
> +	   due to a clang bug.

can you link to or create a bugzilla bug to track this so we don't forget to
update things on our end.

> ChangeLog:20
> +2017-09-20  Keith Miller  <keith_miller at apple.com>
> +
> +	   JSC Xcode build should use unified sources for platform independent
files
> +	   https://bugs.webkit.org/show_bug.cgi?id=177190
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   * Source/cmake/WebKitMacros.cmake:
> +
> +2017-09-19  Keith Miller  <keith_miller at apple.com>
> +
> +	   JSC Xcode build should use unified sources for platform independent
files
> +	   https://bugs.webkit.org/show_bug.cgi?id=177190
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Add a macro for collecting the set of "header" source files and
adding the bundle
> +	   files to the "sources" list.
> +
> +	   * Source/cmake/WebKitMacros.cmake:

double changelog here.