[webkit-reviews] review granted: [Bug 177272] Device iOS 11 builds fail with FileProvider linker errors : [Attachment 321375] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 20 14:58:23 PDT 2017


David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has granted Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 177272: Device iOS 11 builds fail with FileProvider linker errors
https://bugs.webkit.org/show_bug.cgi?id=177272

Attachment 321375: Patch

https://bugs.webkit.org/attachment.cgi?id=321375&action=review




--- Comment #3 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org> ---
Comment on attachment 321375
  --> https://bugs.webkit.org/attachment.cgi?id=321375
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321375&action=review

r=me

> Tools/WebKitTestRunner/Configurations/Base.xcconfig:93
> +FRAMEWORK_SEARCH_PATHS[sdk=iphone*] = $(inherited)
$(WK_PRIVATE_FRAMEWORK_STUBS_DIR)

Nit:  Semi-colon at end of line.


More information about the webkit-reviews mailing list