[webkit-reviews] review granted: [Bug 177269] WSL should not type-check functions in the standard library that it does not use : [Attachment 321367] the patch

[bugzilla-daemon at webkit.org]

JF Bastien <jfbastien at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 177269: WSL should not type-check functions in the standard library that it
does not use
https://bugs.webkit.org/show_bug.cgi?id=177269

Attachment 321367: the patch

https://bugs.webkit.org/attachment.cgi?id=321367&action=review




--- Comment #2 from JF Bastien <jfbastien at apple.com> ---
Comment on attachment 321367
  --> https://bugs.webkit.org/attachment.cgi?id=321367
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321367&action=review

r=me

> Tools/WebGPUShadingLanguageRI/NameContext.js:97
> +	   if (thing.kind == Func) {

=== ?

> Tools/WebGPUShadingLanguageRI/Prepare.js:29
> +    return function(origin, lineNumberOffset, text) {

Why?

> Tools/WebGPUShadingLanguageRI/ProgramWithUnnecessaryThingsRemoved.js:33
> +	   if (statement.origin.originKind == "user")

=== ?

> Tools/WebGPUShadingLanguageRI/ProgramWithUnnecessaryThingsRemoved.js:40
> +    // We need these even if the program doesn't mention them by name.

Why?