[webkit-reviews] review requested: [Bug 177265] Spelling and grammar dots should not overlap : [Attachment 321366] Patch and unit tests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 20 14:18:43 PDT 2017


Daniel Bates <dbates at webkit.org> has asked  for review:
Bug 177265: Spelling and grammar dots should not overlap
https://bugs.webkit.org/show_bug.cgi?id=177265

Attachment 321366: Patch and unit tests

https://bugs.webkit.org/attachment.cgi?id=321366&action=review




--- Comment #2 from Daniel Bates <dbates at webkit.org> ---
Created attachment 321366

  --> https://bugs.webkit.org/attachment.cgi?id=321366&action=review

Patch and unit tests

The implementation of subdivide() is derived from an algorithm that Said
Abou-Hallawa came up with. I added unit tests to avoid creating
platform-specific pixel tests (we do not run pixel tests by default).


More information about the webkit-reviews mailing list