[webkit-reviews] review requested: [Bug 171172] [ATK] atk_table_get_n_rows() and atk_table_get_n_columns() should return values of aria-rowcount and aria-colcount, if present : [Attachment 321326] Patch

[bugzilla-daemon at webkit.org]

Joanmarie Diggs (irc: joanie) <jdiggs at igalia.com> has asked  for review:
Bug 171172: [ATK] atk_table_get_n_rows() and atk_table_get_n_columns() should
return values of aria-rowcount and aria-colcount, if present
https://bugs.webkit.org/show_bug.cgi?id=171172

Attachment 321326: Patch

https://bugs.webkit.org/attachment.cgi?id=321326&action=review




--- Comment #9 from Joanmarie Diggs (irc: joanie) <jdiggs at igalia.com> ---
Comment on attachment 321326
  --> https://bugs.webkit.org/attachment.cgi?id=321326
Patch

(In reply to Build Bot from comment #7)
> Comment on attachment 321326 [details]
> Patch
> 
> Attachment 321326 [details] did not pass mac-wk2-ews (mac-wk2):
> Output: http://webkit-queues.webkit.org/results/4605342
> 
> New failing tests:
> fast/images/animated-gif-webkit-transform.html

I'm failing to understand how a change made in the ATK (WebKitGtk
accessibility) code could cause a non-accessibility test for macOS to fail. If
my patch is really to blame, hints/insight shall be gratefully accepted.

In the meantime, since the one shared accessibility test I tweaked is not
showing up as a failure in macOS, setting r? and clearing the cq-.