[webkit-reviews] review granted: [Bug 174573] Video errors should be instances of Error : [Attachment 321322] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 174573: Video errors should be instances of Error
https://bugs.webkit.org/show_bug.cgi?id=174573

Attachment 321322: Patch

https://bugs.webkit.org/attachment.cgi?id=321322&action=review




--- Comment #21 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 321322
  --> https://bugs.webkit.org/attachment.cgi?id=321322
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321322&action=review

> Source/WebCore/html/HTMLMediaElement.cpp:1045
> +	   promise.rejectType<IDLInterface<DOMException>>(error);

If that is a pattern that will happen often, maybe we should be able to write
it as promise.reject(error) or promise.rejectAsException(error)?