[webkit-reviews] review granted: [Bug 177193] Switch PeerConnection to release logging : [Attachment 321288] Proposed patch.

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 177193: Switch PeerConnection to release logging
https://bugs.webkit.org/show_bug.cgi?id=177193

Attachment 321288: Proposed patch.

https://bugs.webkit.org/attachment.cgi?id=321288&action=review




--- Comment #6 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 321288
  --> https://bugs.webkit.org/attachment.cgi?id=321288
Proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=321288&action=review

> Source/WebCore/Modules/mediastream/PeerConnectionBackend.cpp:223
> +    ALWAYS_LOG(LOGIDENTIFIER, "Set remote description succeeded");

It seems ALWAYS_LOG is taking LOGIDENTIFIER as first parameter in almost all of
the code base right now.
Maybe ALWAYS_LOG should by default log the identifier without the need to pass
LOGIDENTIFIER.
This would end-up with a shorter ALWAYS_LOG. Ditto for INFO_LOG.

> Source/WebCore/platform/mediastream/RTCIceGatheringState.h:48
> +    static String toString(const WebCore::RTCIceGatheringState state)

There is probably a convertEnumerationToString for this one too.

> Source/WebCore/platform/mediastream/RTCSignalingState.h:50
> +	   switch (state) {

Ditto.