[webkit-reviews] review granted: [Bug 168964] [GTK] Completely garbled display in GMail : [Attachment 321310] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has granted Miguel Gomez
<magomez at igalia.com>'s request for review:
Bug 168964: [GTK] Completely garbled display in GMail
https://bugs.webkit.org/show_bug.cgi?id=168964

Attachment 321310: Patch

https://bugs.webkit.org/attachment.cgi?id=321310&action=review




--- Comment #50 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 321310
  --> https://bugs.webkit.org/attachment.cgi?id=321310
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321310&action=review

Thanks!

> Source/WebCore/platform/graphics/ImageBackingStore.h:37
> +#define CAIRO_MAX_IMAGE_SIZE 32768

Use a static variable instead.

> Source/WebCore/platform/graphics/ImageBackingStore.h:185
> +#if USE(CAIRO)
> +	   // If the image is bigger than the cairo limit it can't be
displayed, so we don't event
> +	   // try to decode it.
> +	   if (size.width() > CAIRO_MAX_IMAGE_SIZE || size.height() >
CAIRO_MAX_IMAGE_SIZE)
> +	       return true;
> +#endif

Ok, this is much better than screwing the whole page, but it's a workaround in
the end. Do you think it would be possible to implement support for decoding
and rendering images bigger than the cairo limit? maybe using some kind of
tiles or whatever? If it's possible, please file a bug report and add a FIXME
here with the bug url