[webkit-reviews] review granted: [Bug 177165] Update bot configuration for iOS 11 : [Attachment 321209] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Ryan Haddad
<ryanhaddad at apple.com>'s request for review:
Bug 177165: Update bot configuration for iOS 11
https://bugs.webkit.org/show_bug.cgi?id=177165

Attachment 321209: Patch

https://bugs.webkit.org/attachment.cgi?id=321209&action=review




--- Comment #2 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 321209
  --> https://bugs.webkit.org/attachment.cgi?id=321209
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321209&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/config.json:53
> +		       { "name": "bot216", "platform": "ios-simulator-11" },
> +		       { "name": "bot217", "platform": "ios-simulator-11" },

Some of the bots here are no longer used. It's probably still right to make the
proposed change, but I wanted to point this out to confirm that this is
intentional.

>
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/W
ebKitBuildbot.js:60
> +	   "Apple iOS 11 Release (Build)": {platform:
Dashboard.Platform.iOS11Device, debug: false, builder: true, architecture:
Buildbot.BuildArchitecture.Universal},
> +	   "Apple iOS 11 Simulator Release (Build)": {platform:
Dashboard.Platform.iOS11Simulator, debug: false, builder: true, architecture:
Buildbot.BuildArchitecture.SixtyFourBit},

These are both single architecture, but have different "architecture" values.
We should probably just remove the architecture from configuration.