[webkit-reviews] review denied: [Bug 177117] Web Inspector: Adopt named groups in complex regexes : [Attachment 321166] [PATCH] Proposed Fix
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Sep 19 10:47:36 PDT 2017
Joseph Pecoraro <joepeck at webkit.org> has denied Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 177117: Web Inspector: Adopt named groups in complex regexes
https://bugs.webkit.org/show_bug.cgi?id=177117
Attachment 321166: [PATCH] Proposed Fix
https://bugs.webkit.org/attachment.cgi?id=321166&action=review
--- Comment #6 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 321166
--> https://bugs.webkit.org/attachment.cgi?id=321166
[PATCH] Proposed Fix
View in context: https://bugs.webkit.org/attachment.cgi?id=321166&action=review
> Source/WebInspectorUI/UserInterface/Models/Color.js:65
> + if (match.groups.hex) {
> + let hex = match.group.hex.toUpperCase();
Oops, the second should be `groups.hex` not `group.hex`.
More information about the webkit-reviews
mailing list