[webkit-reviews] review granted: [Bug 176980] On iOS, getData can't get text set by setData during copy event : [Attachment 321183] Fixes the bug by refactoring
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Sep 19 09:29:50 PDT 2017
Darin Adler <darin at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 176980: On iOS, getData can't get text set by setData during copy event
https://bugs.webkit.org/show_bug.cgi?id=176980
Attachment 321183: Fixes the bug by refactoring
https://bugs.webkit.org/attachment.cgi?id=321183&action=review
--- Comment #5 from Darin Adler <darin at apple.com> ---
Comment on attachment 321183
--> https://bugs.webkit.org/attachment.cgi?id=321183
Fixes the bug by refactoring
View in context: https://bugs.webkit.org/attachment.cgi?id=321183&action=review
> Source/WebCore/platform/Pasteboard.h:189
> + virtual void commitToPasteboard(Pasteboard&) { ASSERT_NOT_REACHED(); }
Can we make this pure virtual instead? I’m sure there is some reason we can’t,
but failing at runtime instead of compile time is not a good pattern.
More information about the webkit-reviews
mailing list