[webkit-reviews] review granted: [Bug 177134] WebDriver: Implement commands to get and set the window rect : [Attachment 321196] Patch

[bugzilla-daemon at webkit.org]

Brian Burg <bburg at apple.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 177134: WebDriver: Implement commands to get and set the window rect
https://bugs.webkit.org/show_bug.cgi?id=177134

Attachment 321196: Patch

https://bugs.webkit.org/attachment.cgi?id=321196&action=review




--- Comment #3 from Brian Burg <bburg at apple.com> ---
Comment on attachment 321196
  --> https://bugs.webkit.org/attachment.cgi?id=321196
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321196&action=review

r=me

> Source/WebDriver/ChangeLog:13
> +	   (WebDriver::Session::getToplevelBrowsingContextRect): Helper to get
the window rext. This is used by both get

Nit: 'rect'

> Source/WebDriver/Session.cpp:678
> +void Session::moveToplevelBrowsingContextwindow(double x, double y,
Function<void (CommandResult&&)>&& completionHandler)

Nit: 'moveToplevelBrowsingContextWindow'

> Source/WebDriver/Session.cpp:695
> +void Session::resizeToplevelBrowsingContextwindow(double width, double
height, Function<void (CommandResult&&)>&& completionHandler)

Ditto.