[webkit-reviews] review requested: [Bug 176766] Web Inspector: Implement `queryObjects` Command Line API : [Attachment 321185] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Sep 18 23:20:41 PDT 2017
Devin Rousso <webkit at devinrousso.com> has asked for review:
Bug 176766: Web Inspector: Implement `queryObjects` Command Line API
https://bugs.webkit.org/show_bug.cgi?id=176766
Attachment 321185: Patch
https://bugs.webkit.org/attachment.cgi?id=321185&action=review
--- Comment #15 from Devin Rousso <webkit at devinrousso.com> ---
Created attachment 321185
--> https://bugs.webkit.org/attachment.cgi?id=321185&action=review
Patch
Added a few basic tests. Still not entirely sure what to do about the case
where someone calls `queryObject(Object)` or `queryObject(Array)`. Part of me
thinks it would be good to entirely block those so as to not expose any
internal values, but at the same time it might be useful to see all the
"nameless" objects that a program creates (or just count how many there are).
More information about the webkit-reviews
mailing list