[webkit-reviews] review granted: [Bug 176977] WSL should support enum : [Attachment 321179] the ptach
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Sep 18 20:35:46 PDT 2017
Myles C. Maxfield <mmaxfield at apple.com> has granted Filip Pizlo
<fpizlo at apple.com>'s request for review:
Bug 176977: WSL should support enum
https://bugs.webkit.org/show_bug.cgi?id=176977
Attachment 321179: the ptach
https://bugs.webkit.org/attachment.cgi?id=321179&action=review
--- Comment #5 from Myles C. Maxfield <mmaxfield at apple.com> ---
Comment on attachment 321179
--> https://bugs.webkit.org/attachment.cgi?id=321179
the ptach
View in context: https://bugs.webkit.org/attachment.cgi?id=321179&action=review
> Tools/WebGPUShadingLanguageRI/Intrinsics.js:111
> + type.formatValueFromDoubleLiteral = value => value;
No rounding?
> Tools/WebGPUShadingLanguageRI/SynthesizeEnumFunctions.js:27
> +function synthesizeEnumFunctions(program)
Wow, this is cool! Dynamically generating functions!
I wish I knew how to do this with clang (without emitting a giant string)
> Tools/WebGPUShadingLanguageRI/Test.js:3929
> + Foo war()
> + {
> + return Foo.War;
> + }
> + Foo famine()
> + {
> + return Foo.Famine;
> + }
> + Foo pestilence()
> + {
> + return Foo.Pestilence;
> + }
> + Foo death()
> + {
> + return Foo.Death;
> + }
Couldn't you do, like, months of the year or something?
More information about the webkit-reviews
mailing list