[webkit-reviews] review granted: [Bug 177103] Make ImageFrame::duration() return Seconds instead of float : [Attachment 321143] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 177103: Make ImageFrame::duration() return Seconds instead of float
https://bugs.webkit.org/show_bug.cgi?id=177103

Attachment 321143: Patch

https://bugs.webkit.org/attachment.cgi?id=321143&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 321143
  --> https://bugs.webkit.org/attachment.cgi?id=321143
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321143&action=review

> Source/WebCore/platform/graphics/cg/ImageDecoderCG.cpp:363
> +	   return Seconds(0.1f);

0.1_s or 100_ms

> Source/WebCore/platform/graphics/cg/ImageDecoderCG.cpp:364
> +    return Seconds(duration);

Can this just be "return { duration }"?

> Source/WebCore/platform/image-decoders/ScalableImageDecoder.cpp:206
> +	   return { };

0_s

> Source/WebCore/platform/image-decoders/ScalableImageDecoder.cpp:212
> +    if (buffer->duration() < Seconds(0.011f))

11_ms

> Source/WebCore/platform/image-decoders/ScalableImageDecoder.cpp:213
> +	   return Seconds(0.100f);

100_ms