[webkit-reviews] review granted: [Bug 177054] Web Inspector: console.assert messages shouldn't end in an exclamation point : [Attachment 321046] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Matt Baker
<mattbaker at apple.com>'s request for review:
Bug 177054: Web Inspector: console.assert messages shouldn't end in an
exclamation point
https://bugs.webkit.org/show_bug.cgi?id=177054

Attachment 321046: Patch

https://bugs.webkit.org/attachment.cgi?id=321046&action=review




--- Comment #2 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 321046
  --> https://bugs.webkit.org/attachment.cgi?id=321046
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321046&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/Resizer.js:76
> +	   console.assert(false, `Unexpected Resizer orientation:
${this._orientation}.`);

I'd prefer including the orientation as its own parameter instead of an inline
string.

    console.assert(false, "Unexpected Resizer orientation", this._orientation);