[webkit-reviews] review granted: [Bug 177031] Figure out how WSL will support field overloads like float4.xz and friends : [Attachment 321106] the patch

[bugzilla-daemon at webkit.org]

JF Bastien <jfbastien at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 177031: Figure out how WSL will support field overloads like float4.xz and
friends
https://bugs.webkit.org/show_bug.cgi?id=177031

Attachment 321106: the patch

https://bugs.webkit.org/attachment.cgi?id=321106&action=review




--- Comment #17 from JF Bastien <jfbastien at apple.com> ---
Comment on attachment 321106
  --> https://bugs.webkit.org/attachment.cgi?id=321106
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321106&action=review

Lots of this is over my head for now, first look at WSL :)

r=me with that caveat.

> Tools/WebGPUShadingLanguageRI/Checker.js:40
>	   }

Ah no semicolon!

> Tools/WebGPUShadingLanguageRI/Checker.js:160
> +	       throw new WTypeError(node.origin.originString, "LHS of
read-modify-write is not an LValue: " + node.lVale);

Typo "node.lVale"

> Tools/WebGPUShadingLanguageRI/Checker.js:236
> +	       throw new Error("Cannot get typeForAnd");

Is there some context that can be thrown here? Looked like you have origin
laying around that helps figure out where in the source this comes from?

> Tools/WebGPUShadingLanguageRI/FindHighZombies.js:27
> +function findHighZombies(program)

👍

> Tools/WebGPUShadingLanguageRI/Parse.js:784
> +	       let token = consume("+", "-", "*", "/", "%", "^", "&", "|", "<",
">", "<=", ">=", "==", "++", "--", "&", ".", "~", "<<", ">>", "[");

Does order in "consume" matter here? Because you have "<" before "<<", would it
consume "<" first? I guess you already had "-" before "--" so no?

You also have "&" twice.