[webkit-reviews] review requested: [Bug 177017] [Win] WTF: Add alias for process id to use in place of direct uses of pid_t : [Attachment 321104] Test patch for ews on adding process identifier alias
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Sep 18 10:16:09 PDT 2017
Stephan Szabo <stephan.szabo at sony.com> has asked for review:
Bug 177017: [Win] WTF: Add alias for process id to use in place of direct uses
of pid_t
https://bugs.webkit.org/show_bug.cgi?id=177017
Attachment 321104: Test patch for ews on adding process identifier alias
https://bugs.webkit.org/attachment.cgi?id=321104&action=review
--- Comment #18 from Stephan Szabo <stephan.szabo at sony.com> ---
Created attachment 321104
--> https://bugs.webkit.org/attachment.cgi?id=321104&action=review
Test patch for ews on adding process identifier alias
Missed that the JavaScriptCore one was an API header as well.
Again not sure if putting definitions in each header is correct or if there's a
more general place to put platform specific type information for the API
headers, nor whether it'd be better to still use a type that isn't directly
pid_t in them to prevent non-portable types from leaking.
More information about the webkit-reviews
mailing list