[webkit-reviews] review granted: [Bug 177057] build-webkit spawns fewer subprocesses than ninja uses by default : [Attachment 321054] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 18 08:13:12 PDT 2017


Alex Christensen <achristensen at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 177057: build-webkit spawns fewer subprocesses than ninja uses by default
https://bugs.webkit.org/show_bug.cgi?id=177057

Attachment 321054: Patch

https://bugs.webkit.org/attachment.cgi?id=321054&action=review




--- Comment #4 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 321054
  --> https://bugs.webkit.org/attachment.cgi?id=321054
Patch

We should only make this change for ninja, which automatically determines the
number of jobs to do at the same time.	If we do this for non-ninja builds, it
would make them take ~8x as long because make defaults to using 1 cpu.


More information about the webkit-reviews mailing list