[webkit-reviews] review granted: [Bug 177063] Fill out vector types in WSL's standard library : [Attachment 321075] Patch

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 177063: Fill out vector types in WSL's standard library
https://bugs.webkit.org/show_bug.cgi?id=177063

Attachment 321075: Patch

https://bugs.webkit.org/attachment.cgi?id=321075&action=review




--- Comment #5 from Filip Pizlo <fpizlo at apple.com> ---
Comment on attachment 321075
  --> https://bugs.webkit.org/attachment.cgi?id=321075
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321075&action=review

R=me if you add trap, assuming you thread it through everything the obvious
way.

> Tools/WebGPUShadingLanguageRI/StandardLibrary.js:141
> +    return null;

How about you add a trap operation, that throws WTrapError the way that we
currently do for OOB. 

We should talk about what “trap” means. I think it means that the shader
returns prematurely, possibly leaving some output state unpopulated.