[webkit-reviews] review granted: [Bug 177062] WSL needs to understand && and || : [Attachment 321060] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Sep 17 20:00:28 PDT 2017


Filip Pizlo <fpizlo at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 177062: WSL needs to understand && and ||
https://bugs.webkit.org/show_bug.cgi?id=177062

Attachment 321060: Patch

https://bugs.webkit.org/attachment.cgi?id=321060&action=review




--- Comment #2 from Filip Pizlo <fpizlo at apple.com> ---
Comment on attachment 321060
  --> https://bugs.webkit.org/attachment.cgi?id=321060
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=321060&action=review

> Tools/WebGPUShadingLanguageRI/Evaluator.js:175
> +	   case "&&":

Nice. I like that you’re just using the operator itself.


More information about the webkit-reviews mailing list