[webkit-reviews] review denied: [Bug 177017] [Win] WTF: Add alias for process id to use in place of direct uses of pid_t : [Attachment 320966] Test patch for ews on adding process identifier alias, api private headers using pid_t with override

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Sep 17 09:43:02 PDT 2017


Alexey Proskuryakov <ap at webkit.org> has denied Stephan Szabo
<stephan.szabo at sony.com>'s request for review:
Bug 177017: [Win] WTF: Add alias for process id to use in place of direct uses
of pid_t
https://bugs.webkit.org/show_bug.cgi?id=177017

Attachment 320966: Test patch for ews on adding process identifier alias, api
private headers using pid_t with override

https://bugs.webkit.org/attachment.cgi?id=320966&action=review




--- Comment #17 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 320966
  --> https://bugs.webkit.org/attachment.cgi?id=320966
Test patch for ews on adding process identifier alias, api private headers
using pid_t with override

View in context: https://bugs.webkit.org/attachment.cgi?id=320966&action=review

> Source/JavaScriptCore/API/JSRemoteInspector.h:31
> +#include <wtf/ProcessID.h>

As Tim explained, API headers cannot use wtf.


More information about the webkit-reviews mailing list