[webkit-reviews] review granted: [Bug 177028] Avoid calling String::format() in PlatformCAFilters::setFiltersOnLayer() : [Attachment 320969] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 177028: Avoid calling String::format() in
PlatformCAFilters::setFiltersOnLayer()
https://bugs.webkit.org/show_bug.cgi?id=177028

Attachment 320969: Patch

https://bugs.webkit.org/attachment.cgi?id=320969&action=review




--- Comment #2 from Tim Horton <thorton at apple.com> ---
Comment on attachment 320969
  --> https://bugs.webkit.org/attachment.cgi?id=320969
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=320969&action=review

> Source/WebCore/ChangeLog:8
> +	   String::fromat() is a bigger hammer for what we need to do in this
function.

FROMAT

> Source/WebCore/platform/graphics/ca/cocoa/PlatformCAFiltersCocoa.mm:71
> +    static NeverDestroyed<String> filterNamePrefix ="filter_";

There's a missing space after the =. Also isn't there a way to make this more
efficient b/c it comes from a literal (something like ASCIILiteral? or does
that just happen magically? I don't know. Look around.)