[webkit-reviews] review granted: [Bug 177010] Web Inspector: keyboard shortcut for "Reload page from origin" doesn't match Safari, and doesn't work : [Attachment 320951] Proposed Fix

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Brian Burg <bburg at apple.com>'s
request for review:
Bug 177010: Web Inspector: keyboard shortcut for "Reload page from origin"
doesn't match Safari, and doesn't work
https://bugs.webkit.org/show_bug.cgi?id=177010

Attachment 320951: Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=320951&action=review




--- Comment #10 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 320951
  --> https://bugs.webkit.org/attachment.cgi?id=320951
Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=320951&action=review

r=me, I'll leave it up to you what names you decide to use.

> Source/JavaScriptCore/ChangeLog:9
> +	   Use "reload from origin" nomenclature instead of "reload ignoring
cache".

I don't think we need to do this. Reload ignoring cache is clearer to me than
Reload from origin.

Reload from origin is confusing. What if a page loads resources from many
different origins? How many developers know what origin means? How many after
reading  "from origin" will think (like me) "wow this must be something special
I wonder what it does".

If this really does only ignore the cache for a single origin (the main
resource's origin) then I might be fine with changing the naming.

> Source/WebInspectorUI/UserInterface/Base/Main.js:1837
> +    // Reload page from origin if the button is clicked while the shift key
is pressed down.
> +    PageAgent.reload.invoke({ignoreCache: this.modifierKeys.shiftKey});

So this is a good fix, since this was broken before.

The Network Tab's "Ignore Cache" button appears to be broken, and I don't think
this patch addresses that. That was what I was thinking of before, so we should
file a different bug on that.