[webkit-reviews] review granted: [Bug 176910] [Curl] Create a class dedicated to handle SSL related task : [Attachment 320952] fixed

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Basuke Suzuki
<Basuke.Suzuki at sony.com>'s request for review:
Bug 176910: [Curl] Create a class dedicated to handle SSL related task
https://bugs.webkit.org/show_bug.cgi?id=176910

Attachment 320952: fixed

https://bugs.webkit.org/attachment.cgi?id=320952&action=review




--- Comment #8 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 320952
  --> https://bugs.webkit.org/attachment.cgi?id=320952
fixed

View in context: https://bugs.webkit.org/attachment.cgi?id=320952&action=review

> Source/WebCore/platform/network/curl/CurlSSLHandle.cpp:103
> +	   auto valueIter = (it->value).begin();
> +	   for (; valueIter != (it->value).end(); ++valueIter, ++certsIter) {

it->value should at least be given a name.  This loop can be made to be much
more clear.

> Source/WebCore/platform/network/curl/CurlSSLVerifier.h:91
> +

This is a lot of whitespace.  Let's not.