[webkit-reviews] review granted: [Bug 169231] [WebCrypto] Support Elliptic Curve P-521 : [Attachment 319587] Patch

[bugzilla-daemon at webkit.org]

Jiewen Tan <jiewen_tan at apple.com> has granted Zan Dobersek
<zan at falconsigh.net>'s request for review:
Bug 169231: [WebCrypto] Support Elliptic Curve P-521
https://bugs.webkit.org/show_bug.cgi?id=169231

Attachment 319587: Patch

https://bugs.webkit.org/attachment.cgi?id=319587&action=review




--- Comment #9 from Jiewen Tan <jiewen_tan at apple.com> ---
Comment on attachment 319587
  --> https://bugs.webkit.org/attachment.cgi?id=319587
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319587&action=review

Looks good to me. Thanks for adding the support for P-521.

> Source/WebCore/crypto/mac/CryptoKeyECMac.cpp:226
> +	   ASSERT_NOT_REACHED();

Probably ASSERT_NOT_REACHED() is better?