[webkit-reviews] review granted: [Bug 175164] ASSERTION FAILED: writtenAudioDuration >= readAudioDuration in com.apple.WebCore:WebCore::RealtimeOutgoingAudioSource::isReachingBufferedAudioDataHighLimit() + 222 : [Attachment 320909] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Sep 15 09:48:20 PDT 2017
Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 175164: ASSERTION FAILED: writtenAudioDuration >= readAudioDuration in
com.apple.WebCore:WebCore::RealtimeOutgoingAudioSource::isReachingBufferedAudio
DataHighLimit() + 222
https://bugs.webkit.org/show_bug.cgi?id=175164
Attachment 320909: Patch
https://bugs.webkit.org/attachment.cgi?id=320909&action=review
--- Comment #5 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 320909
--> https://bugs.webkit.org/attachment.cgi?id=320909
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=320909&action=review
> Source/WebCore/platform/mediastream/mac/RealtimeOutgoingAudioSource.cpp:124
> + ASSERT(writtenAudioDuration + 0.0000001 >= readAudioDuration);
The magic number isn't good, can you use WTF::areEssentiallyEqual() instead?
> Source/WebCore/platform/mediastream/mac/RealtimeOutgoingAudioSource.cpp:133
> + ASSERT(writtenAudioDuration + 0.0000001 >= readAudioDuration);
Ditto.
More information about the webkit-reviews
mailing list