[webkit-reviews] review requested: [Bug 176984] WTF: use Forward.h when appropriate instead of Vector.h : [Attachment 320871] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 15 00:06:53 PDT 2017


JF Bastien <jfbastien at apple.com> has asked  for review:
Bug 176984: WTF: use Forward.h when appropriate instead of Vector.h
https://bugs.webkit.org/show_bug.cgi?id=176984

Attachment 320871: patch

https://bugs.webkit.org/attachment.cgi?id=320871&action=review




--- Comment #1 from JF Bastien <jfbastien at apple.com> ---
Created attachment 320871

  --> https://bugs.webkit.org/attachment.cgi?id=320871&action=review

patch

As proposed, here's a patch!

It also updates all the locations in our codebase which a quick hack found
didn't actually need Vector.h. Is this code churn? Yes! Is it the kind WebKit
hates? No! It doesn't make blame any worst, unless you usually blame #include
lines and if you do then seriously I suggest finding something else to do. So
it's "free" code churn.


More information about the webkit-reviews mailing list