[webkit-reviews] review granted: [Bug 176863] We should have a way of preventing a caller from making a tail call and we should use it for ProxyObject instead of using build flags : [Attachment 320847] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Sep 14 17:28:16 PDT 2017
Keith Miller <keith_miller at apple.com> has granted Saam Barati
<sbarati at apple.com>'s request for review:
Bug 176863: We should have a way of preventing a caller from making a tail call
and we should use it for ProxyObject instead of using build flags
https://bugs.webkit.org/show_bug.cgi?id=176863
Attachment 320847: patch
https://bugs.webkit.org/attachment.cgi?id=320847&action=review
--- Comment #10 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 320847
--> https://bugs.webkit.org/attachment.cgi?id=320847
patch
View in context: https://bugs.webkit.org/attachment.cgi?id=320847&action=review
r=me with nit.
> Source/WTF/wtf/NoTailCalls.h:42
> +// from within a given function. For example, if you don't want foo
nit: you could say scope instead of function. here.
>> Source/WTF/wtf/NoTailCalls.h:55
>> +#define NO_TAIL_CALLS() WTF::NoTailCalls _noTailCalls_
>
> An alternate name could be:
> DONT_TAIL_CALL
I think NO_TAIL_CALLS makes more sense. DONT_TAIL_CALL implies to me that the
function can't be tail called, which is the opposite of what this does.
More information about the webkit-reviews
mailing list