[webkit-reviews] review denied: [Bug 176910] [Curl] Create a class dedicated to handle SSL related task : [Attachment 320829] fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 14 16:57:57 PDT 2017


Alex Christensen <achristensen at apple.com> has denied Basuke Suzuki
<Basuke.Suzuki at sony.com>'s request for review:
Bug 176910: [Curl] Create a class dedicated to handle SSL related task
https://bugs.webkit.org/show_bug.cgi?id=176910

Attachment 320829: fix

https://bugs.webkit.org/attachment.cgi?id=320829&action=review




--- Comment #5 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 320829
  --> https://bugs.webkit.org/attachment.cgi?id=320829
fix

View in context: https://bugs.webkit.org/attachment.cgi?id=320829&action=review

>
Source/WebCore/platform/network/curl/CurlSSLHandle.cppSource/WebCore/platform/n
etwork/curl/SSLHandle.cpp:146
> +// CurlSSLVeritifer -------------------------------------------------

I don't think comments like this are helpful.  This one's spelled wrong.

> Source/WebCore/platform/network/curl/CurlSSLHandle.h:45
> +class CurlSSLSettings {

We should have one class per file.  This file contains no class called
CURLSSLHandle.


More information about the webkit-reviews mailing list