[webkit-reviews] review granted: [Bug 176964] Create a launcher for webkit-archives : [Attachment 320842] v1 patch for review

[bugzilla-daemon at webkit.org]

Aakash Jain <aakash_jain at apple.com> has granted Lucas Forschler
<lforschler at apple.com>'s request for review:
Bug 176964: Create a launcher for webkit-archives
https://bugs.webkit.org/show_bug.cgi?id=176964

Attachment 320842: v1 patch for review

https://bugs.webkit.org/attachment.cgi?id=320842&action=review




--- Comment #4 from Aakash Jain <aakash_jain at apple.com> ---
Comment on attachment 320842
  --> https://bugs.webkit.org/attachment.cgi?id=320842
v1 patch for review

View in context: https://bugs.webkit.org/attachment.cgi?id=320842&action=review

> Tools/Scripts/run-webkit-archive:34
> +    current_directory = os.path.abspath(os.path.join(script_path,os.pardir))

Is this code to get the directory name? 
You can probably do current_directory = os.path.dirname(script_path)

> Tools/Scripts/run-webkit-archive:41
> +	   print('No Release or Debug framework directories found, exiting.')

This message can use some polishing, maybe specify where are Release or Debug
directories not found.

> Tools/Scripts/run-webkit-archive:55
> +    script_directory = os.path.dirname(script_path)

script_directory seems to be unused

> Tools/Scripts/run-webkit-archive:61
> +	   if 'Darwin' not in platform.system():

This code should be made a separate function and called from inside main().
e.g.: check_for_valid_platform()