[webkit-reviews] review granted: [Bug 176822] Web Inspector: Canvas: recording parameters that include colors should show an InlineSwatch (2D canvas) : [Attachment 320820] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Sep 14 15:15:45 PDT 2017
Devin Rousso <webkit at devinrousso.com> has granted Matt Baker
<mattbaker at apple.com>'s request for review:
Bug 176822: Web Inspector: Canvas: recording parameters that include colors
should show an InlineSwatch (2D canvas)
https://bugs.webkit.org/show_bug.cgi?id=176822
Attachment 320820: Patch
https://bugs.webkit.org/attachment.cgi?id=320820&action=review
--- Comment #20 from Devin Rousso <webkit at devinrousso.com> ---
Comment on attachment 320820
--> https://bugs.webkit.org/attachment.cgi?id=320820
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=320820&action=review
r=me, but what happened to the tests from the previous patch?
> Source/WebInspectorUI/UserInterface/Models/Color.js:246
> + WI.Color._eightBitChannel(b * 255)
NIT: add trailing comma
More information about the webkit-reviews
mailing list