[webkit-reviews] review granted: [Bug 176949] [Mac] Spelling, grammar and correction dots are painted upside down : [Attachment 320805] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 176949: [Mac] Spelling, grammar and correction dots are painted upside down
https://bugs.webkit.org/show_bug.cgi?id=176949

Attachment 320805: Patch

https://bugs.webkit.org/attachment.cgi?id=320805&action=review




--- Comment #7 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 320805
  --> https://bugs.webkit.org/attachment.cgi?id=320805
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=320805&action=review

> Source/WebCore/platform/graphics/cocoa/GraphicsContextCocoa.mm:322
> +	   CGContextClipToRect(context, destinationRect);

Might as well convert this function (replace the CGContextSaveGState above this
diff) to use CGContextStateSaver.

> Source/WebCore/platform/graphics/cocoa/GraphicsContextCocoa.mm:333
>	   // FIXME: Rather than getting the NSImage and then picking the
CGImage from it, we should do what iOS does and
>	   // just load the CGImage in the first place.

Should we actually do this bit now?