[webkit-reviews] review granted: [Bug 176952] Layout test inspector/debugger/breakpoints/resolved-dump-all-pause-locations.html is flaky. : [Attachment 320815] [PATCH] Proposed Fix
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Sep 14 13:54:45 PDT 2017
Matt Baker <mattbaker at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 176952: Layout test
inspector/debugger/breakpoints/resolved-dump-all-pause-locations.html is flaky.
https://bugs.webkit.org/show_bug.cgi?id=176952
Attachment 320815: [PATCH] Proposed Fix
https://bugs.webkit.org/attachment.cgi?id=320815&action=review
--- Comment #3 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 320815
--> https://bugs.webkit.org/attachment.cgi?id=320815
[PATCH] Proposed Fix
View in context: https://bugs.webkit.org/attachment.cgi?id=320815&action=review
r=me, with a nit
> Source/WebInspectorUI/UserInterface/Protocol/InspectorBackend.js:289
> + console.error("No domain dispatcher registered for domain '" +
this._domainName + "', for event '" + this._domainName + "." + eventName +
"'");
This would be easier to read as a template string.
More information about the webkit-reviews
mailing list