[webkit-reviews] review denied: [Bug 176906] [Curl] Replace the implementation with NetworkLoadMetrics : [Attachment 320804] Fixed

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has denied Basuke Suzuki
<Basuke.Suzuki at sony.com>'s request for review:
Bug 176906: [Curl] Replace the implementation with NetworkLoadMetrics
https://bugs.webkit.org/show_bug.cgi?id=176906

Attachment 320804: Fixed

https://bugs.webkit.org/attachment.cgi?id=320804&action=review




--- Comment #6 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 320804
  --> https://bugs.webkit.org/attachment.cgi?id=320804
Fixed

View in context: https://bugs.webkit.org/attachment.cgi?id=320804&action=review

> Source/WebCore/platform/network/curl/CurlContext.cpp:590
> +std::optional<long> CurlHandle::getPrimaryPort()

Ports are uint16_t's.  It might be worth range checking and returning a
std::optional<uint16_t>

> Source/WebCore/platform/network/curl/CurlDownload.cpp:186
> +	   if (*httpCode >= 200 && *httpCode < 300) {

This is now unchecked use of a std::optional.