[webkit-reviews] review denied: [Bug 176906] [Curl] Replace the implementation with NetworkLoadMetrics : [Attachment 320770] patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has denied Basuke Suzuki
<Basuke.Suzuki at sony.com>'s request for review:
Bug 176906: [Curl] Replace the implementation with NetworkLoadMetrics
https://bugs.webkit.org/show_bug.cgi?id=176906

Attachment 320770: patch

https://bugs.webkit.org/attachment.cgi?id=320770&action=review




--- Comment #2 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 320770
  --> https://bugs.webkit.org/attachment.cgi?id=320770
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=320770&action=review

> Source/WebCore/platform/network/curl/CurlContext.h:294
> +    CURLcode getTimes(double&, double&, double&, double&, double&) const;

We're trying to move away from passing return value references in as
parameters.  Let's make this be a function that takes no parameters and returns
a std::optional<NetworkLoadMetrics> or if you actually need the code a
WTF::Expected<NetworkLoadMetrics, CURLcode>.  The functions above it could use
the same improvement.