[webkit-reviews] review granted: [Bug 176889] Add WKUIDelegatePrivate equivalent of WKPageUIClient's drawHeader, drawFooter, headerHeight, and footerHeight : [Attachment 320737] Patch

[bugzilla-daemon at webkit.org]

Andy Estes <aestes at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 176889: Add WKUIDelegatePrivate equivalent of WKPageUIClient's drawHeader,
drawFooter, headerHeight, and footerHeight
https://bugs.webkit.org/show_bug.cgi?id=176889

Attachment 320737: Patch

https://bugs.webkit.org/attachment.cgi?id=320737&action=review




--- Comment #4 from Andy Estes <aestes at apple.com> ---
Comment on attachment 320737
  --> https://bugs.webkit.org/attachment.cgi?id=320737
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=320737&action=review

> Source/WebKit/UIProcess/WebFrameProxy.cpp:79
> +void WebFrameProxy::loadURL(const WebCore::URL& url)

There's a "using namespace WebCore" at the top of this file, so you don't need
to specify "WebCore::" here.

> Source/WebKit/UIProcess/WebPageProxy.cpp:964
> +void WebPageProxy::loadAlternateHTMLString(const String& htmlString, const
WebCore::URL& baseURL, const WebCore::URL& unreachableURL, API::Object*
userData)

Ditto.

> Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp:2495
> +    getPage(webView).loadAlternateHTMLString(String::fromUTF8(content),
WebCore::URL(WebCore::URL(), String::fromUTF8(baseURI)),
WebCore::URL(WebCore::URL(), String::fromUTF8(contentURI)));

Ditto.