[webkit-reviews] review denied: [Bug 176893] Web Inspector: REGRESSION(r221901): Single frame recordings don't reset the recording navigation item : [Attachment 320744] Patch

[bugzilla-daemon at webkit.org]

Matt Baker <mattbaker at apple.com> has denied Devin Rousso
<webkit at devinrousso.com>'s request for review:
Bug 176893: Web Inspector: REGRESSION(r221901): Single frame recordings don't
reset the recording navigation item
https://bugs.webkit.org/show_bug.cgi?id=176893

Attachment 320744: Patch

https://bugs.webkit.org/attachment.cgi?id=320744&action=review




--- Comment #2 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 320744
  --> https://bugs.webkit.org/attachment.cgi?id=320744
Patch

r-, because we should be able to add test coverage for this. In
recording2d.html whenever RecordingFinished is received, we should check that
WI.CanvasManager.recordingCanvas is null.

I should have added this test when introducing this change.