[webkit-reviews] review denied: [Bug 139438] [CMake] Enable pre-compiled headers (PCH) : [Attachment 320359] Patch (not for landing)

[bugzilla-daemon at webkit.org]

Carlos Alberto Lopez Perez <clopez at igalia.com> has denied Adrian Perez
<aperez at igalia.com>'s request for review:
Bug 139438: [CMake] Enable pre-compiled headers (PCH)
https://bugs.webkit.org/show_bug.cgi?id=139438

Attachment 320359: Patch (not for landing)

https://bugs.webkit.org/attachment.cgi?id=320359&action=review




--- Comment #32 from Carlos Alberto Lopez Perez <clopez at igalia.com> ---
Comment on attachment 320359
  --> https://bugs.webkit.org/attachment.cgi?id=320359
Patch (not for landing)

The patch looks good.
I'm willing to do some benchmarks with it once it works ok.
For now, setting r- due to red EWS.
I tried it also locally and failed to build with:
FAILED: Source/WebCore/WebCore_DERIVED_SOURCES/pch.h.gch 
cd /home/clopez/webkit/webkit/WebKitBuild/Release/Source/WebCore &&
/usr/bin/c++
@/home/clopez/webkit/webkit/WebKitBuild/Release/Source/WebCore/WebCore_DERIVED_
SOURCES/flags -x c++-header -o
/home/clopez/webkit/webkit/WebKitBuild/Release/Source/WebCore/WebCore_DERIVED_S
OURCES/pch.h.gch
/home/clopez/webkit/webkit/WebKitBuild/Release/Source/WebCore/WebCore_DERIVED_S
OURCES/pch.h
In file included from /usr/include/c++/6/bits/stl_algo.h:59:0,
		 from /usr/include/c++/6/algorithm:62,
		 from
/home/clopez/webkit/webkit/Source/WebCore/WebCorePrefix.h:81,
		 from
/home/clopez/webkit/webkit/WebKitBuild/Release/Source/WebCore/WebCore_DERIVED_S
OURCES/pch.h:1:
/usr/include/c++/6/cstdlib:75:25: fatal error: stdlib.h: No such file or
directory
 #include_next <stdlib.h>
			 ^
Which reminds me to bug 161697 (maybe related, take a look)