[webkit-reviews] review granted: [Bug 170570] Web Inspector: Event Listeners section does not update when listeners are added/removed : [Attachment 320625] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Sep 13 15:14:02 PDT 2017
Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<webkit at devinrousso.com>'s request for review:
Bug 170570: Web Inspector: Event Listeners section does not update when
listeners are added/removed
https://bugs.webkit.org/show_bug.cgi?id=170570
Attachment 320625: Patch
https://bugs.webkit.org/attachment.cgi?id=320625&action=review
--- Comment #6 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 320625
--> https://bugs.webkit.org/attachment.cgi?id=320625
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=320625&action=review
r=me Nice tests!
> LayoutTests/inspector/dom/event-listener-add-remove.html:110
> + logListeners(0)
> + .then(resolve, reject);
I really dislike this .then on a random line style. It is so unusual,
especially in a case like this.
More information about the webkit-reviews
mailing list