[webkit-reviews] review denied: [Bug 175265] [GTK][WPE] webkit_cookie_manager_delete_all_cookies doesn't delete the cookies if called before a web process is running : [Attachment 319250] Updated patch

[bugzilla-daemon at webkit.org]

Brady Eidson <beidson at apple.com> has denied Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 175265: [GTK][WPE] webkit_cookie_manager_delete_all_cookies doesn't delete
the cookies if called before a web process is running
https://bugs.webkit.org/show_bug.cgi?id=175265

Attachment 319250: Updated patch

https://bugs.webkit.org/attachment.cgi?id=319250&action=review




--- Comment #22 from Brady Eidson <beidson at apple.com> ---
Comment on attachment 319250
  --> https://bugs.webkit.org/attachment.cgi?id=319250
Updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319250&action=review

Note that this patch is obsoleted by
https://trac.webkit.org/changeset/221834/webkit, and will need to be rethought.

> Source/WebKit/UIProcess/API/APIProcessPoolConfiguration.h:68
> +    WebsiteDataStore* defaultWebsiteDataStore() const { return
m_defaultWebsiteDataStore.get(); }
> +    void setDefaultWebsiteDataStore(WebsiteDataStore& websiteDataStore) {
m_defaultWebsiteDataStore = &websiteDataStore; }

This name is problematic:
"default website data store" is already an established concept in the
APIWebsiteDataStore API.

But also, please note that we need to move *away* from the concept of a process
pool having a default datastore and this patch further cements the concept.