[webkit-reviews] review granted: [Bug 176857] Add WKUIDelegatePrivate equivalent of WKPageUIClient's setIsResizable, getWindowFrame, and setWindowFrame : [Attachment 320657] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Sep 13 11:13:46 PDT 2017
Tim Horton <thorton at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 176857: Add WKUIDelegatePrivate equivalent of WKPageUIClient's
setIsResizable, getWindowFrame, and setWindowFrame
https://bugs.webkit.org/show_bug.cgi?id=176857
Attachment 320657: Patch
https://bugs.webkit.org/attachment.cgi?id=320657&action=review
--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 320657
--> https://bugs.webkit.org/attachment.cgi?id=320657
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=320657&action=review
> Source/WebKit/UIProcess/API/Cocoa/WKUIDelegatePrivate.h:167
> +- (void)_webView:(WKWebView *)webView setIsResizable:(BOOL)isResizable
WK_API_AVAILABLE(macosx(WK_MAC_TBA));
This should likely be setResizeable, or possibly a didChange?, or something
that someone smarter might suggest. "is" is for getters in Cocoaland.
More information about the webkit-reviews
mailing list