[webkit-reviews] review granted: [Bug 176848] [HarfBuzz] Wrong offset returned by HarfBuzzShaper::offsetForPosition in some cases : [Attachment 320647] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 176848: [HarfBuzz] Wrong offset returned by
HarfBuzzShaper::offsetForPosition in some cases
https://bugs.webkit.org/show_bug.cgi?id=176848

Attachment 320647: Patch

https://bugs.webkit.org/attachment.cgi?id=320647&action=review




--- Comment #2 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 320647
  --> https://bugs.webkit.org/attachment.cgi?id=320647
Patch

r=me because this is the path to a better future, but this exacerbates our
complex text selection rendering glitch, bug #148220. You can see that some of
the expected results are now worse than before. E.g.
editing/selection/select-across-readonly-input-4 shows the issue clearly.