[webkit-reviews] review granted: [Bug 175759] Introduce Storage Access API (document parts) as an experimental feature : [Attachment 320580] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted John Wilander
<wilander at apple.com>'s request for review:
Bug 175759: Introduce Storage Access API (document parts) as an experimental
feature
https://bugs.webkit.org/show_bug.cgi?id=175759

Attachment 320580: Patch

https://bugs.webkit.org/attachment.cgi?id=320580&action=review




--- Comment #33 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 320580
  --> https://bugs.webkit.org/attachment.cgi?id=320580
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=320580&action=review

> Source/WebCore/dom/Document.cpp:7337
> +    if ((page && page->chrome().runJavaScriptConfirm(*m_frame,
builder.toString())) || m_grantStorageAccessOverride) {

Please add a FIXME: Don't use runJavaScriptConfirm because it responds
synchronously.