[webkit-reviews] review granted: [Bug 176814] String.prototype.replace() puts extra '<' in result when a named capture reference is used without named captures in the RegExp : [Attachment 320582] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Sep 12 17:18:18 PDT 2017
Mark Lam <mark.lam at apple.com> has granted Michael Saboff <msaboff at apple.com>'s
request for review:
Bug 176814: String.prototype.replace() puts extra '<' in result when a named
capture reference is used without named captures in the RegExp
https://bugs.webkit.org/show_bug.cgi?id=176814
Attachment 320582: Patch
https://bugs.webkit.org/attachment.cgi?id=320582&action=review
--- Comment #3 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 320582
--> https://bugs.webkit.org/attachment.cgi?id=320582
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=320582&action=review
LGTM
> Source/JavaScriptCore/ChangeLog:8
> + The copy and advance indecies where off by one and needed a little
fine tuning.
typo:/indecies/indices/
More information about the webkit-reviews
mailing list