[webkit-reviews] review granted: [Bug 174202] [WebVR] Add IDLs and stubs : [Attachment 319890] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Sergio Villar Senin
<svillar at igalia.com>'s request for review:
Bug 174202: [WebVR] Add IDLs and stubs
https://bugs.webkit.org/show_bug.cgi?id=174202

Attachment 319890: Patch

https://bugs.webkit.org/attachment.cgi?id=319890&action=review




--- Comment #25 from Dean Jackson <dino at apple.com> ---
Comment on attachment 319890
  --> https://bugs.webkit.org/attachment.cgi?id=319890
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319890&action=review

It's unclear to me if we should implement this version (1.1) or the next
version (2.0). Version 1.1 says it is already deprecated. Version 2.0 says it
isn't ready to implement yet. I guess we should start with 1.1.

> Source/WebKit/UIProcess/API/C/WKPreferences.cpp:1881
> +
> +void WKPreferencesSetWebVREnabled(WKPreferencesRef preferencesRef, bool
flag)
> +{
> +    toImpl(preferencesRef)->setWebVREnabled(flag);
> +}
> +
> +bool WKPreferencesGetWebVREnabled(WKPreferencesRef preferencesRef)
> +{
> +    return toImpl(preferencesRef)->webVREnabled();
> +}

I don't think we need the C API entry points.

> Source/WebKit/UIProcess/API/C/WKPreferencesRefPrivate.h:531
> +// Defaults to false.
> +WK_EXPORT void WKPreferencesSetWebVREnabled(WKPreferencesRef, bool flag);
> +WK_EXPORT bool WKPreferencesGetWebVREnabled(WKPreferencesRef);
> +

Ditto.